#409 Client::ConsumeFoodDrink item to be deleted from DB before removing item

Closed
opened 2 years ago by image · 2 comments
image commented 2 years ago

``` else {

        GetPlayer()->GetEquipmentList()->RemoveItem(slot, true);
        database.DeleteItem(GetPlayer()->GetCharacterID(), item, "EQUIPPED");
    }```

wrong order, database.DeleteItem should be first since we have RemoveItem boolean true which deletes the item

``` else { GetPlayer()->GetEquipmentList()->RemoveItem(slot, true); database.DeleteItem(GetPlayer()->GetCharacterID(), item, "EQUIPPED"); }``` wrong order, database.DeleteItem should be first since we have RemoveItem boolean true which deletes the item
devn00b commented 2 years ago
Owner

Fixed pending git update.

client.cpp line 10671 -> 10675

    else {

database.DeleteItem(GetPlayer()->GetCharacterID(), item,EQUIPPED"); GetPlayer()->GetEquipmentList()->RemoveItem(slot, true);

    }
Fixed pending git update. client.cpp line 10671 -> 10675 else { database.DeleteItem(GetPlayer()->GetCharacterID(), item,EQUIPPED"); GetPlayer()->GetEquipmentList()->RemoveItem(slot, true); }
devn00b commented 2 years ago
Owner

54a61e0c39

I've seen, nor heard any further issues from this patch, closing related issues. I Will re-open if some problem pops back up.

https://git.eq2emu.com/devn00b/EQ2EMu/commit/54a61e0c391817e2e01cb5f93bc9fd8c13526afa I've seen, nor heard any further issues from this patch, closing related issues. I Will re-open if some problem pops back up.
Sign in to join this conversation.
Loading...
Cancel
Save
There is no content yet.