#418 items tags(heirloom,lore,etc) need code enforcement

Closed
opened 1 year ago by neatz09 · 3 comments
neatz09 commented 1 year ago
There is no content yet.
image commented 1 year ago
Collaborator
  • Heirloom (with group support, no shared bank available yet)

Heirloom is a characteristic of an item that restricts who it can be traded to. An item flagged as heirloom can not be traded to other players unless they were in the group when it was looted, and then it can only be traded to those specific players within 48 earth hours of looting the item.

However, an item flagged as heirloom can be placed in your personal shared bank slots and traded between characters on the same account at any time.

we don't support shared bank yet thats its own issue: #333

  • Lore

Cannot loot or add item to player whom already has the same item id in their bank, inventory or equipped slots.

  • Lore Equip

Can loot or add item, however cannot equip the same item id beyond one item

  • Stack Lore

Cannot have more than one stack of the item (bank, inv and equip slots?)

  • No Destroy

Player cannot destroy item

  • No Zone

Item is deleted upon zoning

  • Temporary - formerly "no rent" item destroys after being logged out for 30 minutes.

Item is restricted by a timer which then removes it

  • appearance_only 1bd2cbf596
  • building_block - no idea on code requirements?? @neatz
  • evil_only
  • good_only
  • cursed - no idea?? @neatz
  • house_lore - issue #441
  • no repair
  • no value
  • no buy back
  • no sale

no buyback/no sale fixed in: 963d40521e

  • no salvage - Issue #442 created
  • no transmute - seems to have been implemented with transmute via Transmute::ItemIsTransmutable
  • ornate - cannot be adorned (added to IsAdornment check) -- adornments are not supported yet though Issue #439
  • ethereal - no idea?? @neatz
  • indestructible 1bd2cbf596
  • infusable infusable is not supported yet added Issue #438
  • no trade - looks previously implemented, blocks in mail items, trade with player and not allowed in shared bank
  • no experiment - Issue #440 created
- [x] Heirloom (with group support, no shared bank available yet) Heirloom is a characteristic of an item that restricts who it can be traded to. An item flagged as heirloom can not be traded to other players unless they were in the group when it was looted, and then it can only be traded to those specific players within 48 earth hours of looting the item. However, an item flagged as heirloom can be placed in your personal shared bank slots and traded between characters on the same account at any time. we don't support shared bank yet thats its own issue: https://git.eq2emu.com/devn00b/EQ2EMu/issues/333 - [x] Lore Cannot loot or add item to player whom already has the same item id in their bank, inventory or equipped slots. - [x] Lore Equip Can loot or add item, however cannot equip the same item id beyond one item - [x] Stack Lore Cannot have more than one stack of the item (bank, inv and equip slots?) - [x] No Destroy Player cannot destroy item - [x] No Zone Item is deleted upon zoning - [x] Temporary - formerly "no rent" item destroys after being logged out for 30 minutes. Item is restricted by a timer which then removes it - [x] appearance_only https://git.eq2emu.com/devn00b/EQ2EMu/commit/1bd2cbf596d64b5a3794e2229689ef3d91f7a953 - [x] building_block - no idea on code requirements?? @neatz - [x] evil_only - [x] good_only - [x] cursed - no idea?? @neatz - [x] house_lore - issue #441 - [x] no repair - [x] no value - [x] no buy back - [x] no sale no buyback/no sale fixed in: https://git.eq2emu.com/devn00b/EQ2EMu/commit/963d40521e506b369801230b5f803a3c26aa3893 - [x] no salvage - Issue #442 created - [x] no transmute - seems to have been implemented with transmute via Transmute::ItemIsTransmutable - [x] ornate - cannot be adorned (added to IsAdornment check) -- adornments are not supported yet though Issue #439 - [x] ethereal - no idea?? @neatz - [x] indestructible https://git.eq2emu.com/devn00b/EQ2EMu/commit/1bd2cbf596d64b5a3794e2229689ef3d91f7a953 - [x] infusable infusable is not supported yet added Issue #438 - [x] no trade - looks previously implemented, blocks in mail items, trade with player and not allowed in shared bank - [x] no experiment - Issue #440 created
image commented 1 year ago
Collaborator

I am not sure if there is a lore group that we need to define as a column in the DB, in eqemu we have it since items aren't always lore based on item id... Right now the lore properties are based solely on item id.

If we need to add lore group, eqemu/everquest just simply used a integer to distinguish its unique lore group -- we would probably do the same here.

I am not sure if there is a lore group that we need to define as a column in the DB, in eqemu we have it since items aren't always lore based on item id... Right now the lore properties are based solely on item id. If we need to add lore group, eqemu/everquest just simply used a integer to distinguish its unique lore group -- we would probably do the same here.
neatz09 commented 1 year ago
Collaborator

stealing this from the database... no clue if any of these actually have any code enforcement but figured id just put them in a list appearance_only building_block evil_only good_only cursed house_lore no repair no value no buy back no salvage no transmute ornate ethereal(wtfever this is) indestructible infusable no trade no experiment(wtfever that is) free reforge refined unlocked

stealing this from the database... no clue if any of these actually have any code enforcement but figured id just put them in a list appearance_only building_block evil_only good_only cursed house_lore no repair no value no buy back no salvage no transmute ornate ethereal(wtfever this is) indestructible infusable no trade no experiment(wtfever that is) free reforge refined unlocked
image referenced this issue from a commit 1 year ago
Sign in to join this conversation.
Loading...
Cancel
Save
There is no content yet.