#516 DoF client / far journey issues

Closed
opened 1 year ago by image · 1 comments
image commented 1 year ago
  • Profile(Character) -> Options all the checkboxes set the wrong thing (afk, roleplaying, camping, linkdead, lfg, so on)
  • Quest complete reward on Waulon is just an empty window without mariners charm (temp rewards item data was not sent to DoF client, fixed)
  • Constant re-sheething weapon in battle (combat look needs to be properly set on, does with AFK)
  • spells do end cast at the start. Fixed to do start and end cast at appropriate times (struct fix).
  • casting on self says "not a friend" -- should say not an enemy.
  • too far away says "too close"
  • selecting self interrupts /camp
  • food/drink not translated correctly between client/server. Server should be using the up to date values (inventory expanded). And translate those values to the client so the DB and code reflects the proper slots for various reasons (check if valid item for slot, make sure it doesn't overwrite other slots, compatible with other clients) -- this will break a number of inventory slots in DoF clients for existing characters
  • this same issue of food/drink slots extends to a number of other slots which need the same work done -- this will break a number of inventory slots in DoF clients for existing characters
  • broker crashes DoF client when attempting a search
  • examine equipped items didn't work for drink/potentially mismatched other slots
  • item stat review (200's need to be reconsidered)
  • dof client is constantly sending HandleExamineInfoRequest packets for spells. The design is such that we need to send the full spell then when the client follows up with another examine info request packet we need to send a partial spell packet. (Greatly improved performance of DoF cause it was constantly sending these packets for all spells in your book per second!)
  • collections window is broken (items not displaying correctly) - collections now display correctly in journal window. Upon turning in complete collections, client no longer crashes. Outstanding note: DoF client has EXP show up as % of level (60?) instead of just bare XP points. This might need more discovery, but isn't a huge issue right now.
  • player profile inspection inventory, DoF and AoM both display inventory (DoF does not support appearance gear). Cross client inspection works also. Avoidance (DoF and AOM) / ATK (DoF) stats need to be reviewed and matched in the structure, but not a big priority.
  • /who list is broken (if more than one player, by myself /who works) -- structure updated for some unknown bytes tail of packet
  • gestures show up as /emote -- integrated emotes for clients <= 546 (DoF earlier) to check emote DB and use appropriate visual state.
  • some items (scrolls?) are not interpreting right on DoF client (see 61611 item for example) -- looks to start with items 60000+ -- house items now display in DoF
  • Merchant shows "sell to merchant" which is inaccurate, it shows the items to buy and an empty repair window
  • merchant repair window crashes client -- currently worked around by sending buy screen then repair screen.. displays both, need to get buy screen disabled, will be its own git issue.
- [x] Profile(Character) -> Options all the checkboxes set the wrong thing (afk, roleplaying, camping, linkdead, lfg, so on) - [x] Quest complete reward on Waulon is just an empty window without mariners charm (temp rewards item data was not sent to DoF client, fixed) - [x] Constant re-sheething weapon in battle (combat look needs to be properly set on, does with AFK) - [x] spells do end cast at the start. Fixed to do start and end cast at appropriate times (struct fix). - [x] casting on self says "not a friend" -- should say not an enemy. - [x] too far away says "too close" - [x] selecting self interrupts /camp - [x] food/drink not translated correctly between client/server. Server should be using the up to date values (inventory expanded). And translate those values to the client so the DB and code reflects the proper slots for various reasons (check if valid item for slot, make sure it doesn't overwrite other slots, compatible with other clients) -- this will break a number of inventory slots in DoF clients for existing characters - [x] this same issue of food/drink slots extends to a number of other slots which need the same work done -- this will break a number of inventory slots in DoF clients for existing characters - [x] broker crashes DoF client when attempting a search - [x] examine equipped items didn't work for drink/potentially mismatched other slots - [x] item stat review (200's need to be reconsidered) - [x] dof client is constantly sending HandleExamineInfoRequest packets for spells. The design is such that we need to send the full spell then when the client follows up with another examine info request packet we need to send a partial spell packet. (Greatly improved performance of DoF cause it was constantly sending these packets for all spells in your book per second!) - [x] collections window is broken (items not displaying correctly) - collections now display correctly in journal window. Upon turning in complete collections, client no longer crashes. Outstanding note: DoF client has EXP show up as % of level (60?) instead of just bare XP points. This might need more discovery, but isn't a huge issue right now. - [x] player profile inspection inventory, DoF and AoM both display inventory (DoF does not support appearance gear). Cross client inspection works also. Avoidance (DoF and AOM) / ATK (DoF) stats need to be reviewed and matched in the structure, but not a big priority. - [x] /who list is broken (if more than one player, by myself /who works) -- structure updated for some unknown bytes tail of packet - [x] gestures show up as /emote -- integrated emotes for clients <= 546 (DoF earlier) to check emote DB and use appropriate visual state. - [x] some items (scrolls?) are not interpreting right on DoF client (see 61611 item for example) -- looks to start with items 60000+ -- house items now display in DoF - [x] Merchant shows "sell to merchant" which is inaccurate, it shows the items to buy and an empty repair window - [x] merchant repair window crashes client -- currently worked around by sending buy screen then repair screen.. displays both, need to get buy screen disabled, will be its own git issue.
image commented 11 months ago
Collaborator

Fixed by 716f9affa3

Fixed by https://git.eq2emu.com/devn00b/EQ2EMu/commit/716f9affa317edc358615fa9cca017ff21d2e31c
Sign in to join this conversation.
Loading...
Cancel
Save
There is no content yet.