Home Explore Help
Register Sign In
devn00b
/
EQ2EMu
8
2
Fork 0
Files Issues 77 Pull Requests 0 Wiki
Labels Milestones
New Issue

#559 DatabaseResult.cpp and .h GetFieldValueStr(..) is terribly inefficient

Closed
opened 1 month ago by image · 1 comments
image commented 1 month ago

The field_names is an array of pointers, so we have to for-loop o(n) instead of building a map for o(log(n)).

The field_names is an array of pointers, so we have to for-loop o(n) instead of building a map for o(log(n)).
Nellag referenced this issue from a commit 4 weeks ago
Core/Database: Optimised Database::StoreResult by using a map of field names to indices instead of a char pointer array. Issue #559
image commented 3 weeks ago
Collaborator

this was addressed by dc552fc9f6

closing

this was addressed by https://git.eq2emu.com/devn00b/EQ2EMu/commit/dc552fc9f633c98ded0319019bf35eae68bcbd88 closing
image closed 3 weeks ago
Sign in to join this conversation.
Labels
Clear labels
Content LoginServer ModelViewer Needs Assignment On Hold P1 P2 P3 Recast User Input WorldServer bug crash duplicate enhancement invalid limitation missing client feature question security tech debt
No Label
Content
LoginServer
ModelViewer
Needs Assignment
On Hold
P1
P2
P3
Recast
User Input
WorldServer
bug
crash
duplicate
enhancement
invalid
limitation
missing client feature
question
security
tech debt
Milestone
Clear milestone
No Milestone
OmiScorpii
Assignee
Clear assignee
No assignee
1 Participants
Write Preview
Loading...
Cancel
Save
There is no content yet.