#565 All packets that serialize with the serializeCountPacket function need mutex protection

Otevřený
otevřeno před 3 týdny uživatelem image · 2 komentářů
image okomentoval před 3 týdny

the XOR/other packets get constantly created/deleted, if we call the function twice (we are multithreaded) it will cause a crash. We need to prevent with a unique_lock.

the XOR/other packets get constantly created/deleted, if we call the function twice (we are multithreaded) it will cause a crash. We need to prevent with a unique_lock.
image okomentoval před 3 týdny
Spolupracovník

Client::SendRecipeList

PlayerItemList::serialize

EquipmentItemList::serialize

Player::GetSpellBookUpdatePacket <-- this is what we crashed on in the previous instance, but any are possible

PlayerSkillList::GetSkillPacket

Client::SendRecipeList PlayerItemList::serialize EquipmentItemList::serialize Player::GetSpellBookUpdatePacket <-- this is what we crashed on in the previous instance, but any are possible PlayerSkillList::GetSkillPacket
image okomentoval před 3 týdny
Spolupracovník

char sheet is also involved, pretty much anywhere we have XOR packets or temp buffers that get deleted/newed for packets.

char sheet is also involved, pretty much anywhere we have XOR packets or temp buffers that get deleted/newed for packets.
Přihlaste se pro zapojení do konverzace.
Načítání...
Zrušit
Uložit
Není zde žádný obsah.